fix: Always dial to root cluster for single-use certificates#20218
Merged
Conversation
codingllama
force-pushed
the
codingllama/web-ssh-trustedcluster
branch
from
a937587 to
3586698
Compare
Contributor
Author
|
FYI @avatus |
Contributor
Author
zmb3
approved these changes
Jan 13, 2023
avatus
approved these changes
Jan 13, 2023
codingllama
force-pushed
the
codingllama/web-ssh-trustedcluster
branch
2 times, most recently
from
b210cde to
5e828d3
Compare
codingllama
force-pushed
the
codingllama/web-ssh-trustedcluster
branch
from
5e828d3 to
3204b53
Compare
Contributor
|
@codingllama See the table below for backport results.
|
This was referenced Jan 14, 2023
Collaborator
|
I opened backports for this one, @codingllama. Thanks for the fix! |
codingllama
pushed a commit
that referenced
this pull request
Jan 17, 2023
The Web UI terminal wrongly dials to the leaf cluster, in trusted cluster scenarios, to issue single-use certificates (the kind one needs when require_session_mfa` is enabled). This fixes that by always dialing to the root cluster, [a behavior that matches `tsh`][1]. [1]: https://github.com/gravitational/teleport/blob/c23532cc009a67c9e11b505b5686d825fd4f68f8/lib/client/client.go#L455-L480 #20208 Backport #20218 to branch/v10
codingllama
pushed a commit
that referenced
this pull request
Jan 17, 2023
The Web UI terminal wrongly dials to the leaf cluster, in trusted cluster scenarios, to issue single-use certificates (the kind one needs when require_session_mfa` is enabled). This fixes that by always dialing to the root cluster, [a behavior that matches `tsh`][1]. [1]: https://github.com/gravitational/teleport/blob/c23532cc009a67c9e11b505b5686d825fd4f68f8/lib/client/client.go#L455-L480 #20208 Backport #20218 to branch/v11
codingllama
pushed a commit
that referenced
this pull request
Jan 17, 2023
The Web UI terminal wrongly dials to the leaf cluster, in trusted cluster scenarios, to issue single-use certificates (the kind one needs when require_session_mfa` is enabled). This fixes that by always dialing to the root cluster, [a behavior that matches `tsh`][1]. [1]: https://github.com/gravitational/teleport/blob/c23532cc009a67c9e11b505b5686d825fd4f68f8/lib/client/client.go#L455-L480 #20208 Backport #20218 to branch/v9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Web UI terminal wrongly dials to the leaf cluster, in trusted cluster scenarios, to issue single-use certificates (the kind one needs when
require_session_mfais enabled).This fixes that by always dialing to the root cluster, a behavior that matches
tsh#20208